Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated I2C pin names in PinNames.h header #15238

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Updated I2C pin names in PinNames.h header #15238

merged 1 commit into from
Mar 1, 2022

Conversation

deepak-shreshti
Copy link
Contributor

Dear Team,

We have updated the M4KN code to change I2C pin names in "PinNames.h" header.

Kindly check and merge the code.

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from a team February 28, 2022 09:30
@ciarmcom
Copy link
Member

@deepak-shreshti, thank you for your changes.
@ARMmbed/team-toshiba @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 28, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 28, 2022

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 28, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit dcb71e2 into ARMmbed:master Mar 1, 2022
@mergify mergify bot removed the ready for merge label Mar 1, 2022
@mergify
Copy link

mergify bot commented Mar 1, 2022

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Mar 1, 2022
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Mar 1, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 1, 2022

This PR does not contain release version label after merging.

Fixed

@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: toshiba release-version: 6.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepak-shreshti @ciarmcom @0xc0170 @mbed-ci @mbedmain